-
Notifications
You must be signed in to change notification settings - Fork 22
chore: move example workflows #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
follow up to #303
WalkthroughDependabot configuration was narrowed to scan only the repository root for GitHub Actions updates. Documentation examples were updated to reference workflow YAML files moved under .github/workflows/examples instead of docs/examples. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
.github/dependabot.yml (2)
9-15
: If recursion is not guaranteed, add a second updater for the examples pathIf Dependabot doesn’t recurse into subfolders, add a dedicated github-actions updater to keep example workflow references current.
Apply this diff:
updates: - package-ecosystem: github-actions directory: "/" schedule: interval: "weekly" groups: actions: patterns: - "*" + - package-ecosystem: github-actions + directory: "/.github/workflows/examples" + schedule: + interval: "weekly" + groups: + actions: + patterns: + - "*" - package-ecosystem: pip directory: / schedule: interval: "daily" groups: pip: patterns: - "*"
9-15
: Add Dependabot entry for example workflowsDependabot’s GitHub Actions scanner doesn’t recurse into subfolders of
.github/workflows
; workflows under.github/workflows/examples
won’t be picked up by your existing
directory: "/"
entry. To ensure those example workflows get their action pins updated:• In
.github/dependabot.yml
(around lines 9–15), add a second update block:- package-ecosystem: "github-actions" directory: "/.github/workflows/examples" schedule: interval: "weekly"• Or, if your org has the Dependabot multi-directory beta enabled, consolidate both paths:
- package-ecosystem: "github-actions" directories: - "/" - "/.github/workflows/examples" schedule: interval: "weekly"This change will ensure Dependabot scans and updates your nested example workflows.
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
16-23
: Optional: Keep YAML quoting consistentMinor consistency nit:
directory
is quoted for github-actions but unquoted for pip. YAML doesn’t require quotes here, but aligning styles improves readability.- - package-ecosystem: pip - directory: / + - package-ecosystem: pip + directory: "/"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/dependabot.yml
(1 hunks)docs/examples/index.md
(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: 2bndy5
PR: cpp-linter/cpp-linter-action#303
File: .github/dependabot.yml:0-0
Timestamp: 2025-08-12T08:57:29.223Z
Learning: For Dependabot's github-actions ecosystem, multiple directories in the directories list are supported. When directory is "/", Dependabot scans both .github/workflows/ and root action.yml/action.yaml files. Other directory entries are treated as workflow directories and scanned for .yml/.yaml files.
📚 Learning: 2025-08-12T08:57:29.223Z
Learnt from: 2bndy5
PR: cpp-linter/cpp-linter-action#303
File: .github/dependabot.yml:0-0
Timestamp: 2025-08-12T08:57:29.223Z
Learning: For Dependabot's github-actions ecosystem, multiple directories in the directories list are supported. When directory is "/", Dependabot scans both .github/workflows/ and root action.yml/action.yaml files. Other directory entries are treated as workflow directories and scanned for .yml/.yaml files.
Applied to files:
.github/dependabot.yml
🔇 Additional comments (1)
docs/examples/index.md (1)
13-14
: Docs updates align with the file relocationThe includes reflect the new examples location and keep the docs DRY by embedding the actual workflow files. Assuming path resolution is correct, this looks good.
Also applies to: 22-23, 31-32
follow up to #303
Summary by CodeRabbit
Documentation
Chores