Applied changes to percent encoding of query parameters in the uri_builder #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

glynos merged 3 commits into cpp-netlib:master from glynos:append_query_26

Nov 24, 2018

Member

glynos commented Nov 11, 2018 •

edited

Loading

Applies fix for #121 .

I've added append_query_parameter and deprecated append_query. The behaviour of append_query has changed and is strongly recommended not to use it. The behaviour before was unsafe anyway, so that I hope that with the documented warning and deprecation, this should be OK.

I updated some tests to reflect the changes.

Please also consider the consistency of the implementation of query_iterator in your review.


          Applied changes to percent encoding of query parameters in the uri_bu…

6c9b993

…ilder

glynos added the bug fix label

glynos mentioned this pull request

Make uri_builder::append_query() more robust against misuse #121

Closed

mtrenkmann reviewed

View reviewed changes

include/network/uri/detail/encode.hpp Outdated Show resolved Hide resolved

mtrenkmann reviewed

View reviewed changes

include/network/uri/uri_builder.hpp Outdated Show resolved Hide resolved

mtrenkmann reviewed

View reviewed changes

include/network/uri/uri_builder.hpp Outdated Show resolved Hide resolved

mtrenkmann reviewed

View reviewed changes

src/uri_builder.cpp Outdated Show resolved Hide resolved

mtrenkmann reviewed

View reviewed changes

src/uri_builder.cpp Outdated Show resolved Hide resolved

mtrenkmann reviewed

View reviewed changes

src/uri.cpp Show resolved Hide resolved

mtrenkmann reviewed

View reviewed changes

Contributor

mtrenkmann left a comment

I've added a few comments. I see two main issues:

encode_query should not be used.
Consistent naming: a query parameter is a name/value pair. The value part is optional.


          Applied feedback from review

dcf8721

glynos self-assigned this

glynos modified the milestones: 1.0, 1.1


          Updated API of uri_builder and encoding functions

0c40aad

glynos merged commit 983f9cf into cpp-netlib:master

glynos deleted the append_query_26 branch

November 24, 2018 13:18

Contributor

mtrenkmann commented Nov 24, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels