has shared link option #98
Conversation
Closes #93.
| @@ -34,6 +34,16 @@ project( | |||
| #set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELWITHDEBINFO ON CACHE STRING "") | |||
|
|
|||
| option(MRDOX_BUILD_TESTS "Build tests" ON) | |||
| option(MRDOX_BUILD_SHARED "Link shared" OFF) | |||
|
|
|||
| if (MRDOX_BUILD_SHARED) | |||
There was a problem hiding this comment.
is this how its usually done with cmake? I mean, is there not some kind of standard switch or something?
|
I think maybe I did not write the issue up correctly... MrDox has to have a plugin system (i.e. load DLLs / shared libraries dynamically at runtime) so that people can author their own generators without having to build MrDox (and LLVM with it). Or at the least so they don't need to fork the program. For this to work they need to be able to call in to MrDox functions and I am assuming this has to happen via shared linking... |
|
That's a different issue altogether I think. I'll look into it. |
|
#58 is the one. |
Yes, building the plugin architecture is a issue number 58, but this issue is about setting up the build system for it (and having it tested). Most of this pull request looks useful; we need those macros properly set for non-windows platforms, and we need the switches in the CML.. When mrdox is installed from a package the tool should come as a single executable not as an executable with For the tests, who cares. Maybe we should make the mrdox-test link to mrdox dynamically so that CI can test it? |
Closes #93.