Skip to content

[5.x]: 2FA setup screen looks like there's an overlay #16834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartrylant opened this issue Mar 5, 2025 · 8 comments
Open

[5.x]: 2FA setup screen looks like there's an overlay #16834

bartrylant opened this issue Mar 5, 2025 · 8 comments
Labels

Comments

@bartrylant
Copy link
Contributor

What happened?

Description

When a new users is activating his account and wants (needs) to setup 2fa, it looks like there is an overlay on top of the whole page. The user cannot enter anything because as soon as you click anywhere on the page (blueish overlay), the slideout for 2fa disappears.

Steps to reproduce

  1. Make a new user
  2. Click the activation link in the email
  3. Choose a password
  4. Click the button to setup 2fa

Expected behavior

Being able to enter the code.

Actual behavior

Overlay on top of the whole page.

Image

Craft CMS version

5.6.10.2

PHP version

8.4.3

Operating system and version

Linux 6.8.0-54-generic

Database type and version

MySQL 8.4.4

Image driver and version

No response

Installed plugins and versions

@bartrylant bartrylant added the bug label Mar 5, 2025
@i-just
Copy link
Contributor

i-just commented Mar 6, 2025

Hi, thanks for reaching out. I’m not able to reproduce that. What OS/browser are you seeing this in?

@bartrylant
Copy link
Contributor Author

MacOS with Chrome

@i-just
Copy link
Contributor

i-just commented Mar 6, 2025

Thanks! Are there any errors in the console?

@bartrylant
Copy link
Contributor Author

No errors in the console. It works perfectly in Safari.

@brianjhanson
Copy link
Contributor

brianjhanson commented Mar 6, 2025

I'm also not able to reproduce this unfortunately. What's the exact version of Chrome you're using? Do you still see the issue with safeMode enabled?

@belkin
Copy link

belkin commented Apr 18, 2025

I've found a way to consistently reproduce this issue, even with safeMode enabled.

Chrome version: 135.0.7049.96
macOS: 15.4.1 (latest)
Craft CMS: 5.7.1.1

Note: Two-Factor Authentication setup works correctly in Safari.

Steps to Reproduce

  1. On the Two-Step Verification Setup screen, click the Set up button:
Step 1
  1. Enter your password to verify your identity:
Step 2
  1. Submit the password form:

3.1 ✅ Clicking the button loads the expected 2FA setup slide-out:

Expected

3.2 ❌ Pressing Enter on the form results in a broken overlay:

Broken Overlay

@brandonkelly
Copy link
Member

@belkin I can’t reproduce that on my end. Tested on the same versions – macOS 15.4.1, Chrome 135.0.7049.96, and Craft 5.7.1.1.

Are you pressing Return immediately when the slideout is opened, tabbing within it at all?

I did notice that rapidly pressing Return when submitting the elevated session modal could result in two slideouts opening simultaneously, and fixed that for the next release. (7008638)

@belkin
Copy link

belkin commented Apr 22, 2025

@brandonkelly I was originally pressing Return just once to submit the form.

After testing in Incognito mode with all extensions disabled (only Bitwarden was allowed in Incognito mode), I discovered that the issue appears to be caused by the extension.

With Bitwarden disabled, the form submission works correctly — both when clicking the submit button and when pressing Return.

I'm not sure if it's the same case with @bartrylant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants