Skip to content

Make compatible with ECS 12.x and remove call to deprecated method se… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make compatible with ECS 12.x and remove call to deprecated method se… #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/.idea
/vendor
/.DS_Store

# local history
/.history
28 changes: 14 additions & 14 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
{
"name": "craftcms/ecs",
"description": "Easy Coding Standard configurations for Craft CMS projects",
"require": {
"php": "^7.2.5|^8.0.2",
"symplify/easy-coding-standard": "^10.3.3"
},
"autoload": {
"psr-4": {
"craft\\ecs\\": "src"
}
},
"scripts": {
"check-cs": "ecs check --ansi",
"fix-cs": "ecs check --ansi --fix"
"name": "craftcms/ecs",
"description": "Easy Coding Standard configurations for Craft CMS projects",
"require": {
"php": "^7.2.5|^8",
"symplify/easy-coding-standard": "^10.3.3|^12.1"
},
"autoload": {
"psr-4": {
"craft\\ecs\\": "src"
}
},
"scripts": {
"check-cs": "ecs check --ansi",
"fix-cs": "ecs check --ansi --fix"
}
}
39 changes: 21 additions & 18 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions sets/craft-cms-3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
return static function(ECSConfig $ecsConfig): void {
$ecsConfig->import(SetList::PSR_12);

$services = $ecsConfig->services();
$services->remove(MethodArgumentSpaceFixer::class);
if (method_exists($ecsConfig, 'services')) {
$services = $ecsConfig->services();
$services->remove(MethodArgumentSpaceFixer::class);
}

$ecsConfig->ruleWithConfiguration(FunctionDeclarationFixer::class, [
'closure_function_spacing' => FunctionDeclarationFixer::SPACING_NONE,
Expand Down