adding a public accessor to JsonPatch to retrieve the contained opera… #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions. This is needed for external rule-based validation of the patch before applying the patch
|
+1 on needing this as well. |
|
+1 Is this fork dead as well the original project? A very simple PR that I need as well. |
|
@jjlauer It is looking like they are not merging and/or replying to any PR that hasn't been submitted by someone from Box or isn't for Box. I am going to create my own fork and start maintaining there as open source that isn't tied to any organization. See https://github.com/dogote/json-patch |
|
Clearly this is not going to be adopted by this project. Closing to get it out of the list of things I care about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where I have a library that receives a JsonPatch doc. Before applying the patch to another Json doc, my library needs to validate the contents of the JsonPatch. For example you may not replace certain values at certain paths or you must have a particular role to be able to perform particular patch operations. So I need to iterate and validate each operation within the JsonPatch object in order to perform custom validation. In order to do this, I need JsonPatch class to be able to expose the underlying List. This pull request has a change to include a public getOperations() method on the JsonPatch class to return an Immutable copy of the internal operations list.