-
Notifications
You must be signed in to change notification settings - Fork 1
Usage guides: Restore -Cdiscovery.type=single-node
#388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated documentation and Docker Compose examples to start CrateDB with the command-line flag Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (21)
🚧 Files skipped from review as they are similar to previous changes (12)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit cba2c1e. Only if this doesn't work on Windows, it is the better option to keep it, because otherwise CrateDB will easily hit system limits on Linux systems, like: max virtual memory areas vm.max_map_count [65530] is too low, increase to at least [262144]
083c01f
to
dc352de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, do we explain somewhere that this is needed only for developement/testing and it shouldn't be added in prod deployments?
Thanks. I've diverted your suggestion to GH-390. |
About
It was a bad idea to remove
-Cdiscovery.type=single-node
because CrateDB will easily hit system limits on Docker/Linux systems, like:Evaluation
This reverts commit cba2c1e. Only if this doesn't work on Windows, it is the better option to keep it.
Backlog
Please have a look to satisfy Windows users. They are still the major share of seat users by far, and most of them are naturally using Docker Desktop for Windows all day.