Skip to content

CI: Verify support on Python 3.13 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
@@ -17,15 +17,15 @@ jobs:
strategy:
matrix:
os: ['ubuntu-22.04']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
cratedb-version: ['nightly']
sqla-version: ['latest']
pip-allow-prerelease: ['false']

# Another CI test matrix slot to test against prerelease versions of Python packages.
include:
- os: 'ubuntu-latest'
python-version: '3.12'
python-version: '3.13'
cratedb-version: 'nightly'
sqla-version: 'latest'
pip-allow-prerelease: 'true'
6 changes: 4 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-22.04']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
cratedb-version: ['5.5.1']
sqla-version: ['<1.4', '<1.5', '<2.1']
pip-allow-prerelease: ['false']
@@ -29,11 +29,13 @@ jobs:
# SQLAlchemy 1.3 is not supported on Python 3.12 and higher.
- python-version: '3.12'
sqla-version: '<1.4'
- python-version: '3.13'
sqla-version: '<1.4'

# Another CI test matrix slot to test against prerelease versions of Python packages.
include:
- os: 'ubuntu-latest'
python-version: '3.12'
python-version: '3.13'
cratedb-version: '5.5.1'
sqla-version: 'latest'
pip-allow-prerelease: 'true'
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Unreleased
- CI: Verified support on Python 3.13

## 2024/10/07 0.40.0
- Propagate error traces properly, using the `error_trace` `connect_args` option,
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -50,6 +50,7 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Programming Language :: SQL",
@@ -107,7 +108,7 @@ optional-dependencies.release = [
]
optional-dependencies.test = [
"cratedb-toolkit[testing]",
"dask[dataframe]",
"dask[dataframe]; python_version<'3.13'",
"pandas<2.3",
"pueblo>=0.0.7",
"pytest<9",
1 change: 1 addition & 0 deletions tests/bulk_test.py
Original file line number Diff line number Diff line change
@@ -206,6 +206,7 @@ def test_bulk_save_pandas(self, mock_cursor):
# Verify number of batches.
self.assertEqual(effective_op_count, OPCOUNT)

@skipIf(sys.version_info >= (3, 13), "SQLAlchemy/Dask is not supported on Python >=3.13 yet")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because pyarrow, a dependency of dask-expr, does not provide binary wheels for Python 3.13 yet.

@skipIf(sys.version_info < (3, 8), "SQLAlchemy/Dask is not supported on Python <3.8")
@skipIf(SA_VERSION < SA_2_0, "SQLAlchemy 1.4 is no longer supported by pandas 2.2")
@patch("crate.client.connection.Cursor", mock_cursor=FakeCursor)
2 changes: 1 addition & 1 deletion tests/integration.py
Original file line number Diff line number Diff line change
@@ -185,7 +185,7 @@ def create_test_suite():
]

# Don't run DataFrame integration tests on SQLAlchemy 1.3 and Python 3.7.
skip_dataframe = SA_VERSION < SA_2_0 or sys.version_info < (3, 8)
skip_dataframe = SA_VERSION < SA_2_0 or sys.version_info < (3, 8) or sys.version_info >= (3, 13)
if not skip_dataframe:
sqlalchemy_integration_tests += [
"docs/dataframe.rst",