Add preliminary support for running doctests. #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Emilgardis I'm not sure how desirable adding unstable features is, but this seems pretty important to testing cross-compiled libraries, so I've added it behind an environment variable ( The README mentions: ### Unstable Features
Certain unstable features can enable additional functionality useful to
cross-compiling. Note that these are unstable, and may be removed at any
time (particularly if the feature is stabilized or removed), and will
only be used on a nightly channel.
- `CROSS_UNSTABLE_ENABLE_DOCTESTS=true`: also run doctests. |
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
May 26, 2022
Allow values of 0, 1, so values other than `true` or `false` can be provided. `VAR=0`, `VAR=`, `VAR=-0`, or `VAR=false` will evaluate to false, while the rest will evaluate to true. Affects cross-rs#661 and cross-rs#721.
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
May 26, 2022
Allow values of 0, 1, so values other than `true` or `false` can be provided. `VAR=0`, `VAR=`, `VAR=-0`, or `VAR=false` will evaluate to false, while the rest will evaluate to true. Affects cross-rs#661 and cross-rs#721.
bors bot
added a commit
that referenced
this pull request
May 26, 2022
722: Evaluate boolean environment variables as truthy or falsey. r=Emilgardis a=Alexhuszagh Allow values of 0, 1, so values other than `true` or `false` can be provided. `VAR=0`, `VAR=`, `VAR=-0`, or `VAR=false` will evaluate to false, while the rest will evaluate to true. Affects #661 and #721. Co-authored-by: Alex Huszagh <[email protected]>
Emilgardis
requested changes
May 26, 2022
Alexhuszagh
force-pushed
the
issue225
branch
2 times, most recently
from
0919c42 to
a35066d
Compare
Emilgardis
requested changes
May 26, 2022
|
could you squash the changes? feel free to remove the |
This partially addresses cross-rs#225. This only works on nightly, due to the use of the unstable feature [doctest-xcompile](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#doctest-xcompile) The relevant tracking issues are: - rust-lang/cargo#7040 - rust-lang/rust#64245 If the subcommand is `test` and the compiler is nightly, we provide the `-Zdoctest-xcompile` flag if `CROSS_UNSTABLE_ENABLE_DOCTESTS=true`.
|
Build succeeded: |
Alexhuszagh
added
enhancement
no-ci-targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #225.
This only works on nightly, due to the use of the unstable feature doctest-xcompile
The relevant tracking issues are:
If the subcommand is
testand the compiler is nightly, we provide the-Zdoctest-xcompileflag ifCROSS_UNSTABLE_ENABLE_DOCTESTS=true.