-
Notifications
You must be signed in to change notification settings - Fork 144
Update sidebar behavior for v2 docs #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for taking this point of confusion on quickly @tr0njavolta!
Can you describe the behavior change in a bit more detail in the PR description, so we can understand and get aligned on it more easily? 🙇♂️
And the DCO check is failing, can you sign-off your commit? this will be relevant: https://github.com/crossplane/crossplane/tree/main/contributing#certificate-of-origin |
I much prefer this sidebar behavior. I do notice though that if you browse directly to https://deploy-preview-973--crossplane.netlify.app/v2.0/get-started/ you still get the blank page. That could be an issue for folks with outdated links. |
3442c1b
to
3ae9322
Compare
Signed-off-by: Rae Sharp <[email protected]>
3ae9322
to
35fa1a4
Compare
Thanks for the reminders @jbw976 🙇 and sorry for the rushed PR. I've updated the following for master, v1.19, v1.20, v2.0, and v2.0preview: Moved content of |
#974 @tr0njavolta @jbw976 WDYT about this approach? I wonder if we should do both - just expand the sidebar when you click it, but also give an autogenerated list of child pages if you manage to browse to e.g. the 'Get Started' page. I was initially thinking you'd need to explicitly enter the URL for these pages, but currently we link them directly from e.g. https://docs.crossplane.io/v2.0/. |
We chatted on Slack and decided to go with just #974 instead. |
This PR attempts to fix empty index page behavior in the sidebar for v2 docs. Will need to make similar adjustments to nested pages in other versions.