Skip to content

PI-298: Update packages for security and performance improvements #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Hesbon5600
Copy link
Contributor

@Hesbon5600 Hesbon5600 commented Sep 18, 2024

Ticket

PI-298

Upgrade:
ip: 1.1.9
activesupport: 7.0.7.1

Related tickets:
Related PRs:

Type of PR

  • Bugfix
  • New feature
  • Minor changes

Did you make changes to the scaffold?

Changes introduced

Describe the changes being introduced in this PR
Include screenshots if necessary
Please link any documentation reference that relate to the changes

Test and review

Describe how a reviewer should test your PR

@Hesbon5600 Hesbon5600 self-assigned this Sep 18, 2024
@alaisgomes
Copy link
Contributor

Can you take a look at the scaffold update checklist?
I think you need to run bootstrap so the changes propagate to the scaffold cookie-cutter folder

Double check your work locally with those helper scripts checks:

yarn run bootstrap produces no changes besides potential changes in yarn.lock resolved versions
yarn run template produces no changes
yarn run semver check passes

@Hesbon5600
Copy link
Contributor Author

Can you take a look at the scaffold update checklist?

I think you need to run bootstrap so the changes propagate to the scaffold cookie-cutter folder


Double check your work locally with those helper scripts checks:



yarn run bootstrap produces no changes besides potential changes in yarn.lock resolved versions

yarn run template produces no changes

yarn run semver check passes

Thanks @alaisgomes . I'll do that

alaisgomes
alaisgomes previously approved these changes Sep 20, 2024
… and 1.15.1

feat(Gemfile): add activesupport gem with version constraints for compatibility and security reasons
@Hesbon5600 Hesbon5600 changed the title PI-298: Update ip package from 1.1.8 to 1.1.9 for security and performance improvements PI-298: Update packages for security and performance improvements Sep 23, 2024
@Hesbon5600 Hesbon5600 force-pushed the PI-298-package-upgrades branch from 9c14746 to f8bf8cd Compare September 23, 2024 17:47
@driverdan driverdan merged commit 2a1bf94 into develop Sep 25, 2024
@driverdan driverdan deleted the PI-298-package-upgrades branch September 25, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants