Skip to content

Conversation

songgaoye
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

port from crypto-org-chain/cronos#1862

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@songgaoye songgaoye requested a review from a team as a code owner September 12, 2025 04:15
@songgaoye songgaoye requested review from thomas-nguy and randy-cro and removed request for a team September 12, 2025 04:15

This comment has been minimized.

@thomas-nguy
Copy link
Collaborator

thomas-nguy commented Sep 17, 2025

Why do we need this fix in master branch?

This fix is only for chain-main v6

@songgaoye
Copy link
Contributor Author

Why do we need this fix in master branch?

This fix is only for chain-main v6

Do you mean create a new branch release/chain-main-fix-apphash and submit this pull request?

@thomas-nguy
Copy link
Collaborator

thomas-nguy commented Sep 17, 2025

maybe change the target of the PR to release/chain-main-fix-apphash instead of master

@songgaoye songgaoye changed the base branch from master to release/chain-main-fix-apphash September 18, 2025 00:45
@songgaoye
Copy link
Contributor Author

songgaoye commented Sep 18, 2025

fixed it.

@songgaoye songgaoye merged commit 81da645 into release/chain-main-fix-apphash Sep 19, 2025
19 checks passed
@songgaoye songgaoye deleted the song/chain-main-hacky-roothash branch September 19, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants