-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix: reopen async File
passed to Process.exec
and .run
(win32)
#15703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ysbaddaden
wants to merge
5
commits into
crystal-lang:master
Choose a base branch
from
ysbaddaden:fix/win32-process-exec-and-run-with-async-files
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix: reopen async File
passed to Process.exec
and .run
(win32)
#15703
ysbaddaden
wants to merge
5
commits into
crystal-lang:master
from
ysbaddaden:fix/win32-process-exec-and-run-with-async-files
+45
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Apr 24, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Updated to use |
straight-shoota
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
platform:windows
Windows support based on the MSVC toolchain / Win32 API
topic:stdlib:runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments for
input
,output
anderror
must be handles withoutFILE_FLAG_OVERLAPPED
so we can't pass aFile
opened withblocking: false
... but we can reopen the filefrom itsusing#path
ReOpenFile
as blocking.This feels more like a hack than a proper solution. I initially triedReOpenFile
, but I couldn't get it to work, while the crude hack just worked 🤷This is working as long as the file isn't closed, in which case we can just use the current file handle: we can pass an async closed handle (but can't reopen a closed file).
Extracted from #15685