Allow to specify custom CRYSTAL_REPO for forks #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During build crystal, mostly all dist download or clone official git repo. Make sure I could test changes from fork repos, suggest to extract static value with variables. Introduces CRYSTAL_REPO variable, that has default value to official repo.
5 tasks
bcardiff
approved these changes
Nov 14, 2023
straight-shoota
approved these changes
Dec 22, 2023
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Apr 8, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@46c295d This includes the following changes: * crystal-lang/distribution-scripts#296 * crystal-lang/distribution-scripts#297 * crystal-lang/distribution-scripts#294 * crystal-lang/distribution-scripts#291 * crystal-lang/distribution-scripts#274 * crystal-lang/distribution-scripts#286 * crystal-lang/distribution-scripts#281 * crystal-lang/distribution-scripts#270 * crystal-lang/distribution-scripts#263 * crystal-lang/distribution-scripts#273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a Crystal project, the common practice involves either downloading or cloning the official Git repository for most dependencies.
It is essential to ensure the ability to test changes against forked repositories.
I recommend extracting static values into variables for improved flexibility.
This suggestion involves introducing a
CRYSTAL_REPOvariable with a default value pointing to the official repository.