-
Notifications
You must be signed in to change notification settings - Fork 28
Why don't all logged-in Request objects have a token
field?
#140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ah, I think I found something: |
Sending a token header combined with insecure channel credentials is not supported by the node implementation of grpc. |
Hm, it seems that https://github.com/cs3org/reva/blob/v1.11.0/pkg/sdk/session.go#L125-L127 sets the header when communicating over http, but how does it get set when communicating over grpc? |
Ah, I think I got it! https://github.com/cs3org/reva/blob/v1.11.0/cmd/reva/grpc.go#L36 |
Not sure why it calls both |
https://stackoverflow.com/a/37551218/680454 should do something similar in node. |
Yes! OK, I got it now, will create a PR to update https://github.com/cs3org/node-cs3apis#example-usage. |
The existing example didn't show how to set the `x-access-token` header, so it was not really usable. See also cs3org/cs3apis#140.
I see the
WhoAmIRequest
lets you specify thetoken
which you received fromAuthenticateResponse
, but none of the other method Request objects do.I see revad throws "core access token not found" when you try to do for instance a
ListReceivedOCMShared
call.Is there another way to pass the token in a grpc request?
The text was updated successfully, but these errors were encountered: