--assertion-rewrite as an optional flag to override ENABLE_CHECK50_ASSERT #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongxin-liu
approved these changes
Aug 6, 2025
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only way to enable/disable assertion rewriting was by including this line at the top of your file:
# ENABLE_CHECK50_ASSERT = 1However, if the user now wishes to enable it without including this flag, they can simply run:
Otherwise, if they wish to override the assertion rewriting (even if
ENABLE_CHECK50_ASSERThas been set to1orTrue), they can run:If both the argument passed in the command line and the comment left in the check file are conflicting, the presence of the flag takes precedence.