Fix Issue 1502 #1503
Merged
Fix Issue 1502 #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace FusionViewFailPersistent with FusionViewPersistentShmoo
…w_rfactor_symbol_fix
naoyam
reviewed
Mar 7, 2022
Comment on lines
285
to
289
| void replaceValue( | ||
| Fusion* fusion, | ||
| const std::unordered_map<Val*, Val*>& replacement_map) { | ||
| ValReplacementMutator(fusion, replacement_map); | ||
| } |
There was a problem hiding this comment.
This seems like a generic function that's not specific to size replacement. Why not move this somewhere else? Perhaps, ir_utils?
|
Update on this PR?! @rdspring1 |
naoyam
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1502
During
convertRfactorToRootDomain, we need to propagate the replacement extents throughout the entire fusion. Currently, we only update the expressions that use theviewTensorView.