Skip to content

Vectorization validation with rfactor domains #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

Vectorization validation with rfactor domains #1525

merged 1 commit into from
Mar 18, 2022

Conversation

naoyam
Copy link
Collaborator

@naoyam naoyam commented Mar 17, 2022

Fixes #1523

@naoyam naoyam force-pushed the vectorization_validation_rf branch from 309a407 to 4f55528 Compare March 17, 2022 20:29
@naoyam naoyam marked this pull request as ready for review March 17, 2022 20:29
@naoyam naoyam requested a review from csarofeen March 17, 2022 20:29
@naoyam naoyam changed the title Vectorization validation rf Vectorization validation with rfactor domains Mar 17, 2022
csarofeen
csarofeen approved these changes Mar 18, 2022
View reviewed changes
Copy link
Owner

@csarofeen csarofeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@csarofeen csarofeen merged commit 5ba9343 into devel Mar 18, 2022
@naoyam naoyam mentioned this pull request Mar 24, 2022
Merged
@jjsjann123 jjsjann123 mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csarofeen csarofeen csarofeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation of vectorization should be done with rfactor domains rather than root domains
2 participants
@naoyam @csarofeen