Skip to content

Minor cleanup lower_unroll.cpp #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Minor cleanup lower_unroll.cpp #1994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions torch/csrc/jit/codegen/cuda/lower_unroll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,7 @@ bool UnrollPass::canOmitElseClause(kir::ForLoop* fl) {
return true;
}

// Generate the loop nest structure and place it in lowered_exprs
UnrollPass::UnrollPass(const std::vector<Expr*>& exprs) {
FUSER_PERF_SCOPE("GpuLower::Lower::UnrollPass::computeMap");
Copy link
Collaborator Author

@zasdfgbnm zasdfgbnm Sep 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name here is wrong. And, we already have a perf scope for runPass and runPass just calls this function, so I don't think we need a separate perf scope here.

kir::ExprMutator::traverseAndInsert(exprs);
}

Expand Down