Reduce the work to add a new expr: mutator cleanup #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasdfgbnm
changed the title
naoyam
reviewed
Nov 19, 2022
| @@ -480,19 +486,14 @@ class TORCH_CUDA_CU_API Expr : public Statement { | |||
| std::vector<Val*> outputs, | |||
| std::vector<Statement*> attributes); | |||
|
|
|||
| virtual newObjectFuncType* newObjectFunc() const = 0; | |||
There was a problem hiding this comment.
Why does this "newObject" interface now return a function pointer? What's wrong with the previous version?
There was a problem hiding this comment.
Because of this container->removeExpr(op); in the mutate method. When an IR node is removed from a container, its vtable no longer exist, and op->newObject will cause segfault.
There was a problem hiding this comment.
Can we just do op->newObject() before removing it?
There was a problem hiding this comment.
And we can not swap the order of op->newObject and container->removeExpr because this causes some consistency check failure (an IterDomain used in multiple expr).
There was a problem hiding this comment.
C++ does not allow me to do the following either :(
auto fn = op->newObject;
naoyam
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.