Skip to content

Reduce the work to add a new expr: graphviz cleanup #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2022
Merged

Reduce the work to add a new expr: graphviz cleanup #2205

merged 2 commits into from
Nov 19, 2022

Conversation

zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Nov 19, 2022 •
edited
Loading

Example DAG FusionScheduleTransposeComplexDAG1_CUDA:

Before schedule:
ir

After schedule:
ir2

I don't have a sample graph for this DAG before this PR, because TransposeOp is not handled.

@zasdfgbnm zasdfgbnm marked this pull request as ready for review November 19, 2022 06:43
@zasdfgbnm zasdfgbnm marked this pull request as draft November 19, 2022 07:00
@zasdfgbnm zasdfgbnm requested a review from naoyam November 19, 2022 08:12
@zasdfgbnm zasdfgbnm marked this pull request as ready for review November 19, 2022 08:12
csarofeen
csarofeen approved these changes Nov 19, 2022
View reviewed changes
Copy link
Owner

@csarofeen csarofeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zasdfgbnm zasdfgbnm merged commit d165f29 into devel Nov 19, 2022
@zasdfgbnm zasdfgbnm deleted the graphviz branch November 19, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naoyam naoyam naoyam approved these changes

@csarofeen csarofeen csarofeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zasdfgbnm @naoyam @csarofeen