forked from pytorch/pytorch
-
Notifications
You must be signed in to change notification settings - Fork 7
Improve matmul instruction scheduling with loop rotation #2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
6433b65
Loop rotation WIP
zasdfgbnm c8c40db
save
zasdfgbnm 9c544d8
save
zasdfgbnm 62fc4de
use saved ptr
zasdfgbnm ee0af68
lower predicate
zasdfgbnm c48f27b
more fixes
zasdfgbnm 21787cf
move param to fusion
zasdfgbnm cdca970
indexing and predicate - step 1
zasdfgbnm ed2f9f1
cleanup
zasdfgbnm 301c7c5
working
zasdfgbnm da6a426
Merge branch 'devel' of github.com:csarofeen/pytorch into loop-rotation
zasdfgbnm f868b7a
misc improvements
zasdfgbnm e445a0f
prepare matmul schdule for loop rotation
zasdfgbnm caafc29
save
zasdfgbnm 5e87b2f
save
zasdfgbnm 0ffdeb6
save
zasdfgbnm 645d4bd
save
zasdfgbnm b56ee20
setAssertOutOfBound
zasdfgbnm 3b9531c
fix
zasdfgbnm d09a2a0
sass test
zasdfgbnm 76c5326
double buffer fixes
zasdfgbnm d25e941
fix
zasdfgbnm 4581cb5
save
zasdfgbnm 7e91718
fix
zasdfgbnm b92cbbf
fixes
zasdfgbnm 4c5ff2b
rename
zasdfgbnm 51d7311
Do not assert not used
zasdfgbnm 325abad
fix
zasdfgbnm 676b791
remove predicates
zasdfgbnm 8eff58c
save
zasdfgbnm 044889c
save
zasdfgbnm a706ee4
cleanup
zasdfgbnm e7eadc3
Merge branch 'devel' of github.com:csarofeen/pytorch into loop-rotation
zasdfgbnm 26d2509
Merge branch 'devel' of github.com:csarofeen/pytorch into loop-rotation
zasdfgbnm 3ea82fe
save
zasdfgbnm cbb60a2
fix
zasdfgbnm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but asserting different conditions separately provides a better error message. (The line number in the error message will tell me which is violated).