Skip to content

Fix downcast_ptr != nullptr in RandomOp Record Functor #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

rdspring1
Copy link
Collaborator

  • test_uniform and test_normal are failing in the python frontend
  • The arguments of uniform and normal are scalar values not TensorViews.
----------------------------------------------------------------------
ERROR: test_uniform (__main__.TestNvFuserFrontend)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/rspring/workspace/nvf_pytorch/third_party/nvfuser/python_tests/test_python_frontend.py", line 935, in
test_uniform nvf_out, _ = self.exec_nvfuser(fusion_func, inputs)

File "/home/rspring/workspace/nvf_pytorch/third_party/nvfuser/python_tests/test_python_frontend.py", line 46, in
exec_nvfuser fusion_func(fd) 

File "/home/rspring/workspace/nvf_pytorch/nvfuser/__init__.py", line 10, in __exit__
self._finalize_definition() 

RuntimeError: downcast_ptr != nullptr INTERNAL ASSERT FAILED
at "/home/rspring/workspace/nvf_pytorch/third_party/nvfuser/csrc/utils.h":165, please report a bug to PyTorch. 

* test_uniform and test_normal are failing in the python frontend
Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching this.
😕 I'm now wondering how did it pass my local tests?!?!?!

@rdspring1 rdspring1 merged commit 12c1765 into devel Mar 7, 2023
@jjsjann123 jjsjann123 deleted the fix_random_op branch March 7, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants