Fix indexing failure with non-view rfactor #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoyam
changed the title
|
Odd this wasn't caught before, not sure why this is happening and why this fixes it, but I'm comfortable with the change. |
csarofeen
approved these changes
Mar 9, 2023
|
Bandwidth and speedup curves:
Speedup histogram:
The overall results look like mostly within random noises. There are some benchmarks showing 10% degradation, but they are most likely because they are pretty short-running kernels. |
naoyam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2560
Previously, the rfactor ID sets gathered by the CA map did not include reduction rfactors. However, in the repro of #2560, traversing through an reduction rfactor ID is necessary to index patially inlined broadcast tensors. I don't see any reason not to include reduction rfactor IDs in the CA map, nor any potential side effect. Reduction rfactor has been relatively trivial compared to view rfactor IDs as IDs are reduced away, but it still needs to be processed with the ID traversal logic for indexing.