Fix dtype calculation in expr simplifier #2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasdfgbnm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #1900, I find that sometimes expr simplifier will assign the dtype of a value wrongly. This is because expr simplifier is written loosely assuming the dtypes of all
Vals are the same. However, because we are putting pointer types into the expression, we need to be more careful, otherwise we will get wrong kernel code like:This PR changes all passes in the expr simplifier to let it infer dtype from its inputs.
assertCUDAKerneltests😵💫😵💫😵💫😵💫