Skip to content

Dynamic Shared Memory #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2020
Merged

Dynamic Shared Memory #304

merged 2 commits into from
Aug 24, 2020

Conversation

rdspring1
Copy link
Collaborator

  • Create dynamic shared memory pointers and allocate at beginning of kernel
  • Calculate total dynamic shared memory size and pass to launch configuration
  • Track dynamic shared memory nodes in GPU Lower
  • Check if dynamic shared memory size is acceptable for current GPU
  • Test multiple dynamic shared memory buffers with different data types

@rdspring1 rdspring1 force-pushed the rds_smem_dynamic_20_8_18 branch 3 times, most recently from d2089d9 to 867322c Compare August 19, 2020 01:20
csarofeen
csarofeen reviewed Aug 19, 2020
View reviewed changes
Copy link
Owner

@csarofeen csarofeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this PR is really good. I just have some minor comments and some questions for @tlemo

@rdspring1 rdspring1 force-pushed the rds_smem_dynamic_20_8_18 branch from 89ba159 to ed56014 Compare August 19, 2020 18:47
tlemo
tlemo reviewed Aug 19, 2020
View reviewed changes
@rdspring1
Copy link
Collaborator Author

I incorporated the changes from #302 into this PR. It resolves the conflicts between the two PRs. @FDecaYed

tlemo
tlemo reviewed Aug 20, 2020
View reviewed changes
tlemo
tlemo reviewed Aug 20, 2020
View reviewed changes
@csarofeen csarofeen mentioned this pull request Aug 20, 2020
Closed
tlemo
tlemo reviewed Aug 20, 2020
View reviewed changes
tlemo
tlemo reviewed Aug 20, 2020
View reviewed changes
@rdspring1 rdspring1 force-pushed the rds_smem_dynamic_20_8_18 branch 3 times, most recently from c00b004 to 9e00143 Compare August 21, 2020 20:39
FDecaYed
FDecaYed reviewed Aug 21, 2020
View reviewed changes
@rdspring1 rdspring1 force-pushed the rds_smem_dynamic_20_8_18 branch 4 times, most recently from f34596f to 3e00fcf Compare August 24, 2020 20:00
@rdspring1
Initial Dynamic Shared Memory
9fca930 
Check if shared memory usage is within limits for current GPU

Gather buffers in Single Pass

Use single dynamic smem for reduction/broadcast workspace

Align dynamic shared memory by data type
@rdspring1 rdspring1 force-pushed the rds_smem_dynamic_20_8_18 branch from 3e00fcf to 9fca930 Compare August 24, 2020 20:13
tlemo
tlemo approved these changes Aug 24, 2020
View reviewed changes
@rdspring1 rdspring1 merged commit 3136899 into 20_8_18_devel Aug 24, 2020
@csarofeen csarofeen deleted the rds_smem_dynamic_20_8_18 branch June 9, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csarofeen csarofeen csarofeen left review comments

@tlemo tlemo tlemo approved these changes

+1 more reviewer

@FDecaYed FDecaYed FDecaYed left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdspring1 @tlemo @FDecaYed @csarofeen