Fix Inner Dimension Reductions for FP16 to perform just as well as TI. #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kevinstephano
commented
Aug 27, 2020
kevinstephano
commented
- Added fix to Reduction scheduler for Inner Dimension Reductions
- Added a new reduction param: loop_unroll
- Added an Executor method to compile fusions by string for debug
- Fixed Scheduler tests to use randn() so large reductions were not matching on Infs.
…ction Scheduler to have TI level perf for FP16 inner dimension reductions. Fix tests to use randn() so large reductions aren't matching on inf.
…mean to add for outer reductions.
kevinstephano
force-pushed
the
20_8_18_devel_kjs
branch
from
3c18706 to
da1b369
Compare
jjsjann123
approved these changes
Aug 28, 2020
| @@ -36,6 +36,31 @@ std::string FusionExecutor::getStructuredCode(const std::string& kernel) { | |||
| return code; | |||
| } | |||
|
|
|||
| void FusionExecutor::compileFusionFromStr( | |||
There was a problem hiding this comment.
Are these only used for debugging? I don't see any real code using them. Pointing it out in case this is accidentally checked in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.