-
Notifications
You must be signed in to change notification settings - Fork 5
Let define syntax for extensions; Fix #6 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here: https://github.com/csscomb/core/blob/dev/src/core.js#L135 |
It is. Thank you 🐘 |
🆙 |
test/core.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't be sure that map was copied because {}
is the default value it gets even if configuration fails.
I'd offer replacing on line 27 syntax: {}
with syntax: {'.css': 'scss'}
, for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert.equal
check pointers, not values:
assert.equal({}, {}); // => false
let a = {};
let b = a;
assert.equal(a, b); // true
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thank you!
Is Map usage ok? If so, I’ll squash commits. |
Map is ok. Let me know when to merge. |
It’s ready to merge now 🔥 |
Thank you very much 👯 |
When csscomb.js will support this feature? |
I'm interested in this feature too |
Discussion: #6
In
.csscomb.json
:If the implementation is ok, I’ll write tests.