Skip to content

Add CODEOWNERS file #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Add CODEOWNERS file #404

merged 1 commit into from
Jul 11, 2025

Conversation

PlaidCat
Copy link
Collaborator

@PlaidCat PlaidCat commented Jul 9, 2025

Attempting to add a code owners file for new merges

@PlaidCat PlaidCat self-assigned this Jul 9, 2025
@Copilot Copilot AI review requested due to automatic review settings July 9, 2025 21:26
Copilot
Copilot AI reviewed Jul 9, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a CODEOWNERS file to specify default repository owners for pull request reviews.

  • Introduces a CODEOWNERS file at the repo root
  • Assigns four individual GitHub users as default owners

@thefossguy-ciq
Copy link

Isn't CODEOWNERS branch specific? In the docs that I could find, there is no mention of using main or master branch as the global fallthrough in case PR target branch doesn't have a CODEOWNERS file.

thefossguy-ciq
thefossguy-ciq approved these changes Jul 10, 2025
View reviewed changes
Copy link

@thefossguy-ciq thefossguy-ciq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved regardless of my previous comment to see what happens. 🚤

@PlaidCat
Copy link
Collaborator Author

Isn't CODEOWNERS branch specific? In the docs that I could find, there is no mention of using main or master branch as the global fallthrough in case PR target branch doesn't have a CODEOWNERS file.

Gotta start some where 🤷

@PlaidCat PlaidCat merged commit 6ffedb0 into main Jul 11, 2025
@PlaidCat PlaidCat deleted the {jmaple}_codeowners branch July 11, 2025 19:06
github-actions bot pushed a commit that referenced this pull request Aug 8, 2025
@seehearfeel @chenhuacai
LoongArch: BPF: Add struct ops support for trampoline
6abf17d 
Use BPF_TRAMP_F_INDIRECT flag to detect struct ops and emit proper
prologue and epilogue for this case.

With this patch, all of the struct_ops related testcases (except
struct_ops_multi_pages) passed on LoongArch.

The testcase struct_ops_multi_pages failed is because the actual
image_pages_cnt is 40 which is bigger than MAX_TRAMP_IMAGE_PAGES.

Before:

  $ sudo ./test_progs -t struct_ops -d struct_ops_multi_pages
  ...
  WATCHDOG: test case struct_ops_module/struct_ops_load executes for 10 seconds...

After:

  $ sudo ./test_progs -t struct_ops -d struct_ops_multi_pages
  ...
  #15      bad_struct_ops:OK
  ...
  #399     struct_ops_autocreate:OK
  ...
  #400     struct_ops_kptr_return:OK
  ...
  #401     struct_ops_maybe_null:OK
  ...
  #402     struct_ops_module:OK
  ...
  #404     struct_ops_no_cfi:OK
  ...
  #405     struct_ops_private_stack:SKIP
  ...
  #406     struct_ops_refcounted:OK
  Summary: 8/25 PASSED, 3 SKIPPED, 0 FAILED

Signed-off-by: Tiezhu Yang <[email protected]>
Signed-off-by: Huacai Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tylergohl tylergohl tylergohl approved these changes

@thefossguy-ciq thefossguy-ciq thefossguy-ciq approved these changes

@kerneltoast kerneltoast Awaiting requested review from kerneltoast kerneltoast is a code owner

@bmastbergen bmastbergen Awaiting requested review from bmastbergen bmastbergen is a code owner

@shreeya-patel98 shreeya-patel98 Awaiting requested review from shreeya-patel98 shreeya-patel98 is a code owner

Assignees

@PlaidCat PlaidCat

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PlaidCat @thefossguy-ciq @tylergohl