Skip to content

fix(client-vue3): Avoid Maximum recursive updates exceeded #9548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AyHaski
Copy link
Contributor

@AyHaski AyHaski commented May 7, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
In response to the still open #8557
This is basically a copy of #8556

Description of Changes Made (if issue reference is not provided)
I opened this PR with the changes of the closed PR by @nsandroni as the issue is persisting for our project with following version:

  • "@cubejs-client/core": "1.3.11",
  • "@cubejs-client/vue3": "1.3.11"

Minimum reproduction project was created to see if the error still occurs outside of our current frontend project where we wanted to migrate from vue2 to vue3, containing only :

<template>
  <h1>Vue Cube.js </h1>
  <query-builder :cube-api="cubejsApi" :query="queryChart"></query-builder>
</template>

<script>
import cubejs from '@cubejs-client/core';
import {QueryBuilder} from '@cubejs-client/vue3';

const cubejsApi = cubejs(
    'token',
    {
      apiUrl: 'http://localhost:4000/cubejs-api/v1',
    }
);

export default {
  name: 'App',
  components: {
    QueryBuilder,
  },
  data() {
    return {
      queryChart: {
        measures: [
          'ReportProductViews.pisSum'
        ]
      },
      cubejsApi
    };
  }
};
</script>

Error was still present and after adding the changes it fixed the maximum recursive update exceeded error.
It is fine to either merge the closed PR or this one if possible?

@AyHaski AyHaski requested a review from a team as a code owner May 7, 2025 09:00
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 7, 2025
@AyHaski AyHaski changed the title BUG: Avoid Maximum recursive updates exceeded BUG: Avoid Maximum recursive updates exceeded in Vue3 May 7, 2025
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.33%. Comparing base (785142d) to head (aaf1747).
Report is 72 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (785142d) and HEAD (aaf1747). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (785142d) HEAD (aaf1747)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9548       +/-   ##
===========================================
- Coverage   80.38%   57.33%   -23.05%     
===========================================
  Files         395      165      -230     
  Lines       97932    13555    -84377     
  Branches     2278     2278               
===========================================
- Hits        78723     7772    -70951     
+ Misses      18901     5475    -13426     
  Partials      308      308               
Flag Coverage Δ
cube-backend 57.33% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon requested a review from vasilev-alex May 16, 2025 21:12
@vasilev-alex vasilev-alex changed the title BUG: Avoid Maximum recursive updates exceeded in Vue3 fix(client-vue3): Avoid Maximum recursive updates exceeded May 30, 2025
@vasilev-alex vasilev-alex merged commit 5d5f7da into cube-js:master May 30, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants