Skip to content
This repository was archived by the owner on Dec 21, 2024. It is now read-only.

remove reference to strict option #717

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

hertzsprung
Copy link
Contributor

Description

Removed 'Skip undefined tests' section

Motivation & context

Strict option was removed in cucumber 7, see cucumber/cucumber-jvm#2275

Type of change

Doc fix.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change needed additional tests
    • I have added tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@quine-bot
Copy link

quine-bot bot commented Jan 21, 2022

👋 Figuring out if a PR is useful is hard, hopefully this will help.

  • @hertzsprung has been on GitHub since 2009 and in that time has had 50 public PRs merged
  • Don't you recognize them? They've been here before 🎉
  • Here's a good example of their work: hamcrest-json (Hamcrest matchers for comparing JSON documents)
  • From looking at their profile, they seem to be good with Java and HTML.

Their most recently public accepted PR is: hertzsprung#1

@luke-hill luke-hill merged commit 6316bb4 into cucumber:main Jan 21, 2022
@luke-hill
Copy link
Contributor

Forgot we didn't remove this.

I also have no idea what that bot is.... @aslakhellesoy / @mlvandijk any ideas?

@hertzsprung hertzsprung deleted the remove-skip-undefined-tests branch January 21, 2022 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants