Skip to content

Expose UriProvider and refactor context usage #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 20, 2025

🤔 What's changed?

Previously, we exposed <GherkinDocument/> publicly, but without providing a way to give it the UriContext it needs. That is now fixed with <UriProvider/>, which we use in <GherkinDocumentList/>.

Also, fixes #344 while we're here.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented May 20, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 0990a75
🔍 Latest deploy log https://app.netlify.com/projects/cucumber-react-preview/deploys/6832f88a22c6f70008ee5912
😎 Deploy Preview https://deploy-preview-386--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@davidjgoss davidjgoss marked this pull request as ready for review May 25, 2025 11:02
@davidjgoss davidjgoss merged commit 46f7fa6 into main May 25, 2025
2 checks passed
@davidjgoss davidjgoss deleted the uri-context branch May 25, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: uuid must be a valid HTML5 id
1 participant