Attempt to optimize dfa #57

pokey · 2021-08-09T21:54:56Z

I kept almost all functionality, but dropped a couple things I never use, and the grammar is maybe a bit more awkward

Curious what people think

One of my takeaways here is that DFA compilation seems to be quicker if big captures appear towards the end of a command rather than the beginning. @lunixbochs does that sound right to you?

"replace T with X" should change to "change T word X". We no longer support arbitrary format strings here. We can then add "add" with same syntax "add T word X", but by default will modify T to have an "after". In the future, it will be its own action (see Switch targets to object-oriented cursorless#210)
change the recursive descent code for “after”
it’s "[inner | outer | pair] {enclosingScopeType} | (inner | outer | pair)"
And remove insideOutsideType
And switch “tween” to “between”
And switch bringSwapMove grammar back

fixes #50

pokey · 2021-08-09T21:56:49Z

src/actions/multiple_target_action.py

+
+
+mod.list("cursorless_multiple_target_action", desc="Cursorless move or bring actions")
+ctx.lists["self.cursorless_multiple_target_action"] = {"bring", "move", "swap", "call"}


Unified the syntax for all these multi-target commands. Slightly awkward for some of them but not too bad so far; will have to see how well it works for a couple days

I total understand why you did it but I'm not quite happy with it :s

src/compound_targets.py

src/cursorless.talon

pokey · 2021-08-09T21:58:30Z

src/cursorless.talon


 replace <user.cursorless_target> with <user.cursorless_replace_value>$:
    user.cursorless_replace(cursorless_target, cursorless_replace_value)

-reformat <user.cursorless_target> as <user.formatters>:
+format <user.formatters> onto <user.cursorless_target>:


ok so this one is pretty awkward, but surprisingly swapping these two captures seems to improve DFA compilation. We could prob come up with better terminology here

Maybe we should just remove onto and make it format camel blue air

src/modifiers/surrounding_pair.py

src/primitive_target.py

lunixbochs · 2021-08-10T00:55:08Z

Talon can pre-optimize multiple commands that begin and end with the same capture in some cases. Maybe that's what you're seeing.

src/primitive_target.py

src/modifiers/surrounding_pair.py

src/modifiers/head_tail.py

src/modifiers/containing_scope.py

src/actions/multiple_target_action.py

AndreasArvidsson · 2021-08-13T17:34:43Z

src/modifiers/surrounding_pair.py

+
+mod.list("cursorless_pair_symbol", desc="A symbol that comes in pairs, eg brackets")
+ctx.lists["self.cursorless_pair_symbol"] = {
+    "skis": "backtickQuotes",


Can't we make do with just brick wrap?

…talon into pokey-dfa-optimization

AndreasArvidsson · 2021-08-13T18:43:35Z

src/actions/actions.py

    MakeshiftAction("drink cell", "jupyter.insertCellAbove"),
+    MakeshiftAction("follow", "editor.action.revealDefinition"),


Personally I use reveal definition much more than I use find. Maybe we should rename find instead?

Attempt to optimize DFA

15a5804

pokey changed the base branch from master to develop August 9, 2021 21:55

pokey requested a review from AndreasArvidsson August 9, 2021 21:55