Repack seems to only works on valid delimiters?

[Kn0rk]

quad repack [W]hiskey

Will replace the curly brackets around the function rather than the single quotes around the (fake) string. In Java single quotes are only used for characters and double quotes are used for strings. As such defining a string with single quotes is incorrect. I am assuming that the delimiter search is based on the parser which does not recognize the single quotes as delimiters.

To reproduce:

Create a java file in the vscode and paste:

public class TestSingleQuoteDelimiter {
    
    public static void main(String[] args) {
        String notAString = 'this will not work';
    }
  
}

The result after the command is:

public class TestSingleQuoteDelimiter {
    
    public static void main(String[] args) "
        String notAString = 'this will not work';
    "
    
}

[pokey]

@AndreasArvidsson would #1600 help here?

[Kn0rk]

Yes, I think that should fix it. Since tree sitter would not know what to do with the single quotes they should remain as valid delimiters.

Srry I didn’t find that issue when i was searching for similar issues.

[AndreasArvidsson]

I think so

[AndreasArvidsson]

Now supported