Skip to content

Typescript: item doesn't work for const imports #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexhwoods opened this issue Jan 10, 2022 · 3 comments · Fixed by #709
Closed

Typescript: item doesn't work for const imports #441

alexhwoods opened this issue Jan 10, 2022 · 3 comments · Fixed by #709
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alexhwoods
Copy link
Contributor

import { A, B, C } from 'foo'

In the above example, you would expect chuck item bat to delete the const import B, but you get the error Couldn't find containing collectionItem

@alexhwoods
Copy link
Contributor Author

(if it's not clear, this is a low priority issue)

@alexhwoods
Copy link
Contributor Author

Also, compound ranges can work in this situation

chuck comma past bat

@pokey
Copy link
Member

pokey commented Jan 10, 2022

Fwiw this will be solved by #357, but that's a bigger change so it's possible we can do something to address this specific case in the meantime

@pokey pokey added the enhancement New feature or request label Jan 10, 2022
@pokey pokey added the good first issue Good for newcomers label Jan 18, 2022
@AndreasArvidsson AndreasArvidsson self-assigned this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants