Skip to content

Add parameterList scope type #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
pokey opened this issue Jan 18, 2022 · 4 comments · Fixed by #2907
Closed
1 task

Add parameterList scope type #493

pokey opened this issue Jan 18, 2022 · 4 comments · Fixed by #2907
Assignees
Labels
enhancement New feature or request

Comments

@pokey
Copy link
Member

pokey commented Jan 18, 2022

When inside a function, saying eg "take argue list" will select the list of function parameters.

@pokey pokey added the enhancement New feature or request label Jan 18, 2022
@pokey pokey added help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Jan 18, 2022
@Will-Sommers
Copy link
Collaborator

Heyo - curious if this is still a good first issue as the help wanted label was pulled off.

@pokey
Copy link
Member Author

pokey commented Mar 9, 2022

Yes still good first issue. I removed "help wanted" label from all issues marked "good first issue" because to me the latter implies the former. Would be a bit misleading to label something "good first issue" if we don't want help with it 😄

@Will-Sommers
Copy link
Collaborator

Heyo @pokey — looking at this one again since I'm near it. Do we want this to be distinct from the all modifier?

Also, some specifics. We'd like a single selection here?
I'm curious about the check mark related to #242, ping me on slack?

@pokey
Copy link
Member Author

pokey commented May 31, 2022

Heyo @pokey — looking at this one again since I'm near it. Do we want this to be distinct from the all modifier?

Is your point that we could do this one using "all arg"? I think that is the case if your mark is somewhere in the parameter list. However, this scope type should work from anywhere within the function body as well

We'd like a single selection here?

Yes

I'm curious about the check mark related to #242, ping me on slack?

Sure lmk when you wanna discuss. Basically, when #672 is merged, we'll be able to say "pour arg air" to insert a comma after argument "air" and leave cursor right before the comma. For parameterList, we want to be sure that the user can say "pour arg list" from anywhere within the function, and it will add a comma after last arg and leave cursor there, or if there are no args, just leave cursor between parens where arg list should go. Make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants