Skip to content

fold/unfold requires funk modifier #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasArvidsson opened this issue Jul 6, 2021 · 1 comment · Fixed by #401
Closed

fold/unfold requires funk modifier #72

AndreasArvidsson opened this issue Jul 6, 2021 · 1 comment · Fixed by #401
Labels
bug Something isn't working

Comments

@AndreasArvidsson
Copy link
Member

None of these work:
fold air
fold this

You have to say:
folk funk air
fold funk

@pokey
Copy link
Member

pokey commented Jul 6, 2021

Yes this one is to work around the fact that when you say eg "fold every entry" on a map, if one of the entries is a single line, and you ask VSCode to fold it, VSCode will end up folding the entire map. Thus, cursorless will refuse to fold a single-line target to avoid this scenario.

We could either:

  • see if VSCode has an api to determine if a target is the first line of a fold and use that to determine whether to fold
  • Try to fold single-line targets anyway if every target is one line (including the case where there is only one target and it is one line)
  • Special case the "every" modifier, because that's the only place I've hit this issue

@pokey pokey added the bug Something isn't working label Jul 6, 2021
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants