Skip to content

Remove usage of object return type for getCloneParameters #898

Closed
@pokey

Description

@pokey

Currently, getCloneParameters has a weak type because it needs to be used in createContinuousRangeTarget, cloneWith, and isEqual. We'd like to move these 3 consumer functions into the derived classes, and instead have them call polymorphic implementations. That way we get strong types via template specialisation while still avoiding code duplication

Note that strong typing here would have caught at least two different bugs, eg #895

Metadata

Metadata

Assignees

No one assigned

    Labels

    code qualityImprovements to code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions