Workaround for number_small performance on old knausj version
#1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasArvidsson
approved these changes
Oct 10, 2022
…-on-old-knausj-version
AndreasArvidsson
deleted the
pokey/workaround-for-numbersmall-performance-on-old-knausj-version
branch
cursorless-bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
Co-authored-by: Andreas Arvidsson <[email protected]>
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
…orless-dev#1026) Co-authored-by: Andreas Arvidsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1021
Note that I opted to make our own capture because I figured if the user wasn't using our
rowcommands at all, they'd be surprised when all of a sudden theirnumber_smallchanged in VSCodeDecided to just add something to wiki for simplicity https://github.com/cursorless-dev/cursorless/wiki/Troubleshooting#custom-number_small-capture-is-not-being-used-by-cursorless
Checklist