Surrounding pairs: Fall back to text based algorithm when error node is detected. #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasArvidsson
changed the title
pokey
reviewed
Jul 3, 2023
| @@ -148,3 +160,22 @@ function processSurroundingPairCore( | |||
| scopeType, | |||
| ); | |||
| } | |||
|
|
|||
| function nodeHasError(node: SyntaxNode, includeChildren = false): boolean { | |||
There was a problem hiding this comment.
This seems quite conservative. Are there test cases that fail if you don't eg check grand-siblings?
There was a problem hiding this comment.
The added test for example. The error node is a child to an ancestor of the selected node.
There was a problem hiding this comment.
as discussed, let's use your proposed version for now and if it becomes bothersome we can revisit. see also #1600
pokey
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
Checklist