Test on PR and push to master #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brxck
force-pushed
the
ci-test
branch
13 times, most recently
from
f7bbbc8 to
f6235ff
Compare
pokey
approved these changes
Aug 1, 2021
pokey
reviewed
Aug 1, 2021
| @@ -82,6 +82,7 @@ suite("recorded test cases", async function () { | |||
|
|
|||
| // Wait for cursorless to set up decorations | |||
| cursorlessApi.addDecorations(); | |||
| await new Promise((resolve) => setTimeout(resolve, 100)); | |||
There was a problem hiding this comment.
this shouldn't be necessary; let's figure out how to remove it in a follow-up
|
@brxck Is it only mac that needs the sleep time? If that's the case we could probably do something like this. Not as optimal as removing the sleep totally foriall platforms but still better than having them where they are not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs tests for linux, mac, and windows on every PR and push to master.
Tests occasionally flake out, it seems like adding a 100ms wait after decoration set up solves this. I've run the tests a few times successfully now. The timeout could be smaller, but things are pretty bad on the macos runner which is pretty dang slow. I'm guessing because of this:
From what I've been able to read, it doesn't seem like we're going to be able to do much about that...?