Skip to content

Made interface names targetable as keys #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2023
Merged

Made interface names targetable as keys #1873

merged 4 commits into from
Sep 9, 2023

Conversation

AndreasArvidsson
Copy link
Member

Fixes #1790

Checklist

  • I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

auscompgeek
auscompgeek reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are type aliases handled already?

@AndreasArvidsson
Copy link
Member Author

It is now!

auscompgeek
auscompgeek reviewed Sep 9, 2023
View reviewed changes
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about object types in function signatures? 😅

@AndreasArvidsson
Copy link
Member Author

AndreasArvidsson commented Sep 9, 2023 •
edited
Loading

It does now!!! :D

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Sep 9, 2023
Merged via the queue into main with commit 162bcf7 Sep 9, 2023
@AndreasArvidsson AndreasArvidsson deleted the tsInterfaceKey branch September 9, 2023 09:16
@auscompgeek auscompgeek added the lang-typescript TypeScript/JavaScript grammar support label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auscompgeek auscompgeek auscompgeek left review comments

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
lang-typescript TypeScript/JavaScript grammar support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for key in typescript interfaces
3 participants
@AndreasArvidsson @auscompgeek @pokey