Skip to content

Updated how line decorations are shown #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2021
Merged

Updated how line decorations are shown #194

merged 5 commits into from
Aug 7, 2021

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Aug 6, 2021 •
edited
Loading

  • Line decorations are now always shown for the correct line
  • Decorations for line/paragraph with position before/after uses non line decoration.
    • This means that the decorations aren't shown for empty lines
  • Before line and paragraph are adjusted to not include indentations on line with text
    • chuck before line keeps indentation
  • Fixed line decoration on float command

@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner August 6, 2021 12:51
pokey
pokey reviewed Aug 6, 2021
View reviewed changes
pokey
pokey reviewed Aug 7, 2021
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please add tests for behaviour change

@AndreasArvidsson AndreasArvidsson linked an issue Aug 7, 2021 that may be closed by this pull request
"float" highlights wrong line when applied to last line of file #197
Closed
@pokey pokey merged commit a73ff87 into master Aug 7, 2021
@pokey pokey deleted the decorations_line branch August 7, 2021 12:48
@pokey pokey mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"float" highlights wrong line when applied to last line of file
2 participants
@AndreasArvidsson @pokey