Skip to content

Add iteration scope for markdown items #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add iteration scope for markdown items #2135

merged 1 commit into from
Dec 14, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Dec 14, 2023

Checklist

@AndreasArvidsson
Copy link
Member

We should really merge the facet pr and then add scope tests for all the iteration scopes we are missing.

@pokey
Copy link
Member Author

pokey commented Dec 14, 2023

sure, let's collect them on #2134, but I don't see why this one shouldn't go in? I just ran into this today

@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Dec 14, 2023 •
edited
Loading

Sure but fixing bugs without adding test isn't our normal mo and test should contain scope test in our new world was my thoughts.

@pokey pokey added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 730349d Dec 14, 2023
@pokey pokey deleted the pokey/add-iteration-scope-for-markdown-items branch December 14, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pokey @AndreasArvidsson