-
-
Notifications
You must be signed in to change notification settings - Fork 84
In memory text document #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In memory text document #2520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few quick thoughts; still need to review edit code
packages/common/src/ide/inMemoryTextDocument/InMemoryTextDocument.ts
Outdated
Show resolved
Hide resolved
packages/common/src/ide/inMemoryTextDocument/InMemoryTextDocument.test.ts
Outdated
Show resolved
Hide resolved
packages/common/src/ide/inMemoryTextDocument/InMemoryTextDocument.test.ts
Outdated
Show resolved
Hide resolved
@pokey Ready for another look :) |
Made a bunch of tweaks and added a failing test. I personally think the test should pass, but we should just see how a VSCode editor handles that situation and do the same thing |
Ok your new test is now passing. I've tested and vscode is doing exactly what your test is specifying. |
Ha nice. Yeah we rely on that behaviour in our range updater |
Checklist