-
-
Notifications
You must be signed in to change notification settings - Fork 84
Update docs to clarify that all actions require a target #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to clarify that all actions require a target #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good improvements here; thanks! I left some comments
@@ -16,7 +16,7 @@ def get_actions(): | |||
"rewrap", | |||
] | |||
simple_actions = { | |||
key: value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is the one that is most controversial. It's ok with me, but there were objections to how much noise it adds to the cheatsheet cc/ @AndreasArvidsson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with Tara Roys and a few other users at the cursorless meetup on 4/10 and they all were in favor of adding the T's for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If people prefer it that way: go ahead :)
Co-authored-by: Pokey Rule <[email protected]>
Here's my original PR for what it's worth cursorless-dev/cursorless-talon#112 |
Curious why this one is still marked as draft. What's missing? |
Because I marked it when I first made the request and forgot to unmark it. |
Cool—that was my theory 😊 |
Mind adding a screenshot to the PR description? Would be good to do a quick visual sanity check before I hit that merge button |
Ok thanks for that. I believe you mentioned this in your other issue, but looks like Special marks has fallen off the bottom now. Not sure if that's caused by your work here or just new scope types, but mind moving it to the top of the next column? I believe you can just swap lines 125 and 127 in https://github.com/cursorless-dev/cursorless/blob/main/cursorless-talon/src/cheatsheet/cheat_sheet.py#L125-L127 Thanks so much! |
Closes #456
