Skip to content

Fit interior range to content #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 21, 2022
Merged

Fit interior range to content #715

merged 19 commits into from
Jun 21, 2022

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jun 1, 2022 •
edited
Loading

Fixes #713

Checklist

@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review June 1, 2022 09:41
@AndreasArvidsson AndreasArvidsson requested a review from pokey as a code owner June 1, 2022 09:41
@pokey pokey linked an issue Jun 1, 2022 that may be closed by this pull request
Update inside content range to only contain actual content and not whitespace #713
Closed
Base automatically changed from pokey/issue69-Support-fully-compositional-modifiers to main June 7, 2022 12:58
@pokey pokey force-pushed the fitInteriorToContent branch from 023cdf7 to 0b786e9 Compare June 7, 2022 18:42
@pokey
Copy link
Member

pokey commented Jun 7, 2022

Performed git surgery. Original branch at https://github.com/cursorless-dev/cursorless/tree/bak/fitInteriorToContent; feel free to delete if this branch looks ok

pokey
pokey requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice direction; left some comments

pokey
pokey reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@pokey pokey left a comment •
edited by AndreasArvidsson
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Stop using CommonTargetParameters for parameters to InteriorTarget; instead use fullInteriorRange and then construct contentRange before passing to BaseTarget

pokey
pokey reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@pokey pokey left a comment •
edited by AndreasArvidsson
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically there! In addition to a few minor comments inline:

  • Would be good to add a "change" test where the core is empty
  • Would be good to add a "change" test where the core includes only whitespace

@AndreasArvidsson AndreasArvidsson merged commit b6081a2 into main Jun 21, 2022
@AndreasArvidsson AndreasArvidsson deleted the fitInteriorToContent branch June 21, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update inside content range to only contain actual content and not whitespace
2 participants
@AndreasArvidsson @pokey