Skip to content

fix: #48, using requests session instead of cf session #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021
Merged

fix: #48, using requests session instead of cf session #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions garminconnect/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import logging
import json
import re
import requests
import cloudscraper
from enum import Enum, auto

Expand All @@ -29,7 +30,8 @@ def __init__(self, email, password, is_cn=False):
global SIGNIN_URL
self.email = email
self.password = password
self.req = cloudscraper.CloudScraper()
self.cf_req = cloudscraper.CloudScraper()
self.req = requests.session()
self.logger = logging.getLogger(__name__)
self.display_name = ""
self.full_name = ""
Expand Down Expand Up @@ -107,15 +109,15 @@ def login(self):
self.logger.debug(
"Login to Garmin Connect using POST url %s", SIGNIN_URL)
try:
response = self.req.get(
response = self.cf_req.get(
SIGNIN_URL, headers=self.headers, params=params)

response = self.req.post(
response = self.cf_req.post(
SIGNIN_URL, headers=self.headers, params=params, data=data)
if response.status_code == 429:
raise GarminConnectTooManyRequestsError("Too many requests")

response.raise_for_status()
self.req.cookies = self.cf_req.cookies
self.logger.debug("Login response code %s", response.status_code)
except requests.exceptions.HTTPError as err:
raise GarminConnectConnectionError("Error connecting") from err
Expand Down