This repository was archived by the owner on Oct 1, 2020. It is now read-only.
fix default config to only require babel-loader and @babel/preset-env if there is no override #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if there is no override
…ader-requirement-local
|
Thanks! |
|
Version Tip: safely upgrade dependency @cypress/webpack-preprocessor in your project using next-update |
jamesarosen
reviewed
Mar 14, 2019
| const defaultBabelLoaderRules = () => { | ||
| return [ | ||
| { | ||
| test: /\.js?$/, |
There was a problem hiding this comment.
Did you mean to remove the x? This will match .js and .j files.
There was a problem hiding this comment.
Nope, this is a mistake that wasn't caught!
Apologies.
panzarino
pushed a commit
to cypress-io/cypress
that referenced
this pull request
Sep 17, 2020
…ck-preprocessor#38) * fix default config to only require babel-loader and @babel/preset-env if there is no override * remove references to jsx * move babel deps to optional dependencies * fix formatting / add comments about optional babel deps * lazy-load default options so that babel deps don’t need to be installed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix default config to only require babel-loader and @babel/preset-env if there is no override
Fixes #37