cy.stub().log(false) shouldn't disable # stub counts

[exalted]

Current behavior

Currently cy.stub().log(false) will also disable showing # calls in the UI which, IMO, isn't what one would expect.

See the below screenshot:

Desired behavior

When .log(false) is called, the stub command log shouldn't appear (this is not the issue), BUT the # calls should still show.

Test code to reproduce

Here's the repo to reproduce: https://github.com/exalted/cypress-stub-log-bug. All you need to do is to run npm run cypress:open.

Cypress Version

8.3.1

Other

No response

[sainthkh]

Confirmed that it doesn't work.

it('as expected, *does* log AND shows # calls', () => {
  cy.intercept('https://example.cypress.io', cy.stub().log(true).as('foo'))

  cy.visit('https://example.cypress.io')

  cy.get('@foo').should('have.been.calledOnce')
})

it('as expected, does *not* log BUT doesn\'t shows # calls either', () => {
  cy.intercept('https://example.cypress.io', cy.stub().log(false).as('foo'))

  cy.visit('https://example.cypress.io')

  cy.get('@foo').should('have.been.calledOnce')
})

At first, I was wondering this is a bug or a proposal. But according to the doc, log() function exists to hide excessive command logs.

You can chain a .log(bool) method to disable cy.stub() calls from being shown in the Command Log. This may be useful when your stubs are called an excessive number of times.

I guess the count is not something excessive. So, I labeled it as ready for work.

[exalted]

Side note: (not related to the original "issue") why there's a different api to hide logs in this case (i.e., cy.stub().log(false) VS hypothetical cy.stub({log:false})) is also a mystery to me.